[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D74023#1872315 <https://reviews.llvm.org/D74023#1872315>, @HsiangKai wrote:

> Sorry, I didn't see your newest comments before I updated the revision. About adding support to yaml2obj, I will think about it. Could we prepare another patch for yaml2obj modification?
>  I found that I didn't take care 64-bits formatting. I will focus on taking care of 64-bits formatting first.


A separate patch for yaml2obj would be fine from my point of view. Also, regarding the 64-bit formatting, consider putting 32-bit and 64-bit formatting in the same test and using the new yaml2obj option "-D" to share the code, i.e. something like:

  # RUN: yaml2obj %s -D BITS=32 -o %t.32
  # RUN: yaml2obj %s -D BITS=64 -o %t.64
  
  --- !ELF
  FileHeader:
    Class:   ELFCLASS[[BITS]]
    Data:    ELFDATA2LSB
    Type:    ET_REL
    Machine: EM_RISCV
  etc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023