[PATCH] D74368: [TBLGEN] Fix subreg value overflow in DAGISelMatcher

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/TableGen/dag-isel-subregs.td:11
+
+class Indexes<int N> {
+  list<int> all = [0,   1,  2,  3,  4,  5,  6 , 7,
----------------
Can you split all of these register definitions into a template file in Common? I'll want to re-use this at some point


================
Comment at: llvm/utils/TableGen/DAGISelMatcherGen.cpp:725
+        StringRef Name = Def->getName();
+        const CodeGenSubRegIndex *I = RB.lookupSubRegIndex(Name);
+        assert(I && "Cannot find subreg index by name!");
----------------
Actually, why do you need to do the name lookup at all? Can't you juts do CodeGenRegBank.getSubRegIdx(Def)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74368/new/

https://reviews.llvm.org/D74368