[PATCH] D72685: [PowerPC] Exploit VSX rounding instrs for rint

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

In D72685#1868618 <https://reviews.llvm.org/D72685#1868618>, @lkail wrote:

> Correct me if I'm wrong. `rint(x)` returns `x` if `x` is an NaN. However, intruction like `XSRDPIC` may turn `SNAN` to `QNAN`. Does it matter?


It sounds like a problem. I don't have an IEEE reference handy, but I'm told POSIX forbids it.

I'm sorry I'm not a PowerPC guy, I'm more of a SystemZ guy, so I can't sign off on these changes. The PPCISelLowering.cpp changes look reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72685/new/

https://reviews.llvm.org/D72685