[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

Wed Feb 12 06:59:54 PST 2020

jhenderson added a comment.

In D72992#1872015 <https://reviews.llvm.org/D72992#1872015>, @jhenderson wrote:

> In D72992#1871939 <https://reviews.llvm.org/D72992#1871939>, @thakis wrote:
>
> > This broke tests everywhere when the experimental AVR backend is enabled, e.g. http://45.33.8.238/
> >
> > Please take a look, and if it takes a while to fix please revert while you investigate.
>
>
> I have something else going on on my machine at the moment, so this will be tricky for me to sort out. If somebody else could fix it, that would be great. The actual fix should be trivial. In llvm/test/MC/AVR/symbol_relocation.s, add the line `; CHECK-NEXT: OFFSET TYPE VALUE` immediately after the CHECK for "RELOCATION RECORDS".

I finished what I was doing and submitted a quick fix. I haven't got the time to enable an experimental target on my machine, so the fix is technically speculative, but I'm confident in it. If there are more failures of the same kind, please consider fixing them directly rather than asking me to fix them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992