[PATCH] D74474: [mlir] support creating memref descriptors from static shape with non-zero offset

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 06:22:22 PST 2020


ftynse requested changes to this revision.
ftynse added a comment.
This revision now requires changes to proceed.

Can you add a tests where the non-zero offset is exercised?

Nit: you could have kept the loop order reversed to spare yourself the effort of changing the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74474/new/

https://reviews.llvm.org/D74474





More information about the llvm-commits mailing list