[PATCH] D74322: GlobalISel: Extend narrowing to G_ASHR

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 01:38:52 PST 2020


foad added a comment.

In D74322#1871587 <https://reviews.llvm.org/D74322#1871587>, @foad wrote:

> I had to tweak Combiner::combineMachineInstrs to create a ConstantFoldingMIRBuilder instead of plain MachineIRBuilder, but then your new tests still pass even if I delete the "NarrowShiftAmt == 0" special cases for all of shl, lshr and ashr.


Sorry, forget that, I was testing the wrong thing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74322/new/

https://reviews.llvm.org/D74322





More information about the llvm-commits mailing list