[PATCH] D74443: [lld][Hexagon] convert call x at GDPLT to call __tls_get_addr

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 22:38:26 PST 2020


MaskRay added a comment.

> The linker must rebind the call x at GDPLT to call __tls_get_addr in order to dereference the tls variable.

This is weird. Is it fixable in the psABI?



================
Comment at: lld/ELF/Relocations.cpp:1978
 
+/*
+ * The following aid in the conversion of call x at GDPLT to call __tls_get_addr
----------------
`//`


================
Comment at: lld/ELF/Relocations.cpp:1985
+bool HexagonNeedsTLSSymbol(ArrayRef<OutputSection *> outputSections) {
+  bool NeedTLSSymbol = false;
+  forEachInputSectionDescription(
----------------
lld uses `variableName`


================
Comment at: lld/ELF/Relocations.h:117
 
+void HexagonTLSSymbolUpdate(ArrayRef<OutputSection *> outputSections);
+bool HexagonNeedsTLSSymbol(ArrayRef<OutputSection *> outputSections);
----------------
lld uses `functionName`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74443/new/

https://reviews.llvm.org/D74443





More information about the llvm-commits mailing list