[PATCH] D74322: GlobalISel: Extend narrowing to G_ASHR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 19:46:28 PST 2020


arsenm added a comment.

In D74322#1867403 <https://reviews.llvm.org/D74322#1867403>, @foad wrote:

> Is it really worth splitting ashr into three separate cases? Can't CSE and constant folding do it all for you?


I feel weird relying on such things, especially when I can see the cases. If I just delete the special case, it does not manage to take care of it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74322/new/

https://reviews.llvm.org/D74322





More information about the llvm-commits mailing list