[PATCH] D74442: AMDGPU: Add option to disable CGP division expansion

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 14:13:35 PST 2020


arsenm created this revision.
arsenm added reviewers: rampitec, cfang, kerbowa.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

The division expansions in AMDGPUCodeGenPrepare can't be relied on for
correctness, since they punt to later optimization and possibly
legalization in some cases. We still need a way to be able to write
tests for the legalizer versions of the expansion. This is mostly for
GlobalISel, since the expected optimzations is expecting aren't
implemented.

      

The interaction with the flag to expand 64-bit division in the IR is
pretty confusing, but these flags have different purposes.


https://reviews.llvm.org/D74442

Files:
  llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/udiv.i32.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74442.243995.patch
Type: text/x-patch
Size: 11782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200211/e2e140ec/attachment.bin>


More information about the llvm-commits mailing list