[PATCH] D74425: [DebugInfo]: Added support for DWARFv5 Info section header parsing in llvm-dwp utility.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:156
+      return make_error<DWPError>(
+          "unit type DW_UT_split_compile type not found in debug_info header");
+  }
----------------
dblaikie wrote:
> Might be worth specifying the unit type that was found? At least even if it's just the integer value "unexpected unit type 0x3 found in debug_info".
> 
> This should also be tested. (the existing test case could have a second CU in it that just has an incorrect unit type in its header)
Wrapped this as string, since DWPError expects a string.

> This should also be tested. (the existing test case could have a second CU in it that just has an incorrect unit type in its header)

I've tested it locally, error production works fine. Should I also add negative test case.?
If I add this in existing test case, then DWP packaging will detect/produce error and we'll loose primary verification for positive/Everthing fine case/ working llvm-dwp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74425/new/

https://reviews.llvm.org/D74425