[PATCH] D74429: scudo: Fix various test failures, mostly on 32-bit.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 12:24:21 PST 2020


pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/size_class_map.h:27
   static u32 getMaxCachedHint(uptr Size) {
-    DCHECK_LE(Size, (1UL << Config::MaxSizeLog) + Chunk::getHeaderSize());
     DCHECK_NE(Size, 0);
----------------
cryptoad wrote:
> Isn't that still true?
Yes and we're now checking it in the derived classes since this class doesn't know the value of MaxSize.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74429/new/

https://reviews.llvm.org/D74429





More information about the llvm-commits mailing list