[PATCH] D70970: [llvm-objcopy][WebAssembly] Add dump/add/remove-section support

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/wasm/add-section.test:2
+## Test --add-section. This test dumps and removes the section first and checks
+## that adding it back doesn't change the result.
+# RUN: yaml2obj %s -o %t
----------------
Would it be worth checking that the initial and final objects are byte-for-byte identical somehow?


================
Comment at: llvm/utils/gn/secondary/llvm/tools/llvm-objcopy/BUILD.gn:75
     "llvm-objcopy.cpp",
+    "wasm/Object.cpp",
     "wasm/Reader.cpp",
----------------
Is it now the expectation that we update .gn files along with cmake?   (BTW, do you use gn locally?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70970/new/

https://reviews.llvm.org/D70970