[PATCH] D74303: [CFI] cfi directive insertion for callee-save-registers in CFIInstrInserter pass

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added a comment.

Thanks for working on this, I think in general it looks good.

Wasn't there a verifier that was running with EXPENSIVE_CHECKS for the previously supported directives? Can we add the registers as well?

More comments inline.



================
Comment at: llvm/lib/CodeGen/CFIInstrInserter.cpp:81
+    /// Set of callee saved registers saved at basic block entry.
+    std::set<unsigned> IncomingCSRSaved;
+    /// Set of callee saved registers saved at basic block exit.
----------------
You can use `BitVector`s as sets of registers, with the supported bitwise operations to provide similar set operations as std::set.


================
Comment at: llvm/test/CodeGen/X86/cfi-inserter-callee-save-register.mir:6
+--- |
+  define void @_Z3foobPl(i64* nocapture readonly %a) {
+  entry:
----------------
Does this test actually need the IR?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74303/new/

https://reviews.llvm.org/D74303