[PATCH] D73602: [SVE] Add support for lowering GEPs involving scalable vectors.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:3917
+      TypeSize ElementSize = DL->getTypeAllocSize(GTI.getIndexedType());
+      // We intentionally mask away the high bits here; ElementSize may not
+      // fit in IdxTy.
----------------
efriedma wrote:
> sdesmalen wrote:
> > I'm not sure I understand this comment; why would ElementSize not fit into IdxTy?
> If you're on a 32-bit target, and you have a GEP over a type larger than 4GB.  (Not sure this is something that *should* be supported, but we have at least one testcase in the LLVM tree.)
Ah okay, sounds a bit obscure indeed, but that makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73602/new/

https://reviews.llvm.org/D73602