[PATCH] D74307: [MLIR] Support memrefs with complex element types.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 09:17:28 PST 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/IR/StandardTypes.cpp:336
   // Check that memref is formed from allowed types.
-  if (!elementType.isIntOrFloat() && !elementType.isa<VectorType>())
+  if (!elementType.isIntOrFloat() && !elementType.isa<VectorType>() &&
+      !elementType.isa<ComplexType>())
----------------
This is missing an update to UnrankedMemRefType. Also, did you check to make sure that no documentation needs to be updated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74307/new/

https://reviews.llvm.org/D74307





More information about the llvm-commits mailing list