[PATCH] D74404: [DebugInfo] Fix reading addresses in DWARFDebugAddr.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D74404#1869936 <https://reviews.llvm.org/D74404#1869936>, @ikudrin wrote:

> - Removed the `YAML` part from the test.
>
>   Yes, initially, I added it to demonstrate that there is no real address encoded in the raw data of `.debug_addr`. I feel like I heard about an architecture where addends sometimes were encoded both in relocations and in the relocation target.


Yeah, I believe some of those exist - so it's certainly worth it to have looked into that to validate your understanding, but just doesn't make as much sense as a permanent test. (the other aspect: the dump test as-is fails before your change & passes after, so that should be sufficient)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74404/new/

https://reviews.llvm.org/D74404