[PATCH] D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows

[Jeremy Morse via Phabricator via llvm-commits]

jmorse created this revision.
jmorse added reviewers: TWeaver, Orlando, StephenTozer, rnk.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When writing the Windows dbgeng driver for Dexter, I couldn't work out why it would either launch a process and leave it free running, or if I started the process suspended, never do anything with it. The result was a hack to create and attach processes manually. This has been flaking out on Reids Windows buildbot, and clearly wasn't a good solution.

Digging into this, it turns out that the "normal" cdb / windbg behaviour of breaking whenever we attach to a process is not the default: it has to be explicitly requested from the debug engine. This patch does so (by setting DEBUG_ENGOPT_INITIAL_BREAK in the engine options), after which we can simply call "CreateProcessAndAttach2" and everything automagically works.

No test for this behaviour: everything was just broken before.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74409

Files:
  debuginfo-tests/dexter/dex/debugger/dbgeng/README.md
  debuginfo-tests/dexter/dex/debugger/dbgeng/client.py
  debuginfo-tests/dexter/dex/debugger/dbgeng/control.py
  debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
  debuginfo-tests/dexter/dex/debugger/dbgeng/setup.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74409.243861.patch
Type: text/x-patch
Size: 9505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200211/112eaeab/attachment.bin>