[PATCH] D74406: Add RsqrtOp to LLVM dialect.

[Stephan Herhut via Phabricator via llvm-commits]

herhut added a reviewer: ftynse.
herhut added a comment.

Feel free to remove the changes to `log`. But with your change it seems even less consistent than before.

This should be cleaned up, though.



================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td:755
 
-def LLVM_LogOp : LLVM_Op<"intr.log", [NoSideEffect]>,
+def LLVM_LogOp : LLVM_Op<"intr.log", [NoSideEffect, SameOperandsAndResultType]>,
                    Arguments<(ins LLVM_Type:$in)>,
----------------
Hmm, these could all be `UnaryIntrinsicsOp`, no? Or am I missing something?

Not that you need to clean this up but as you touched this one, why not the others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74406/new/

https://reviews.llvm.org/D74406