[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

[Alfredo Dal'Ava Júnior via Phabricator via llvm-commits]

adalava added a comment.

In D71600#1868284 <https://reviews.llvm.org/D71600#1868284>, @efriedma wrote:

> On master, atomic.c is not built by default.  It's only built if you explicitly request it with something like the CMake flag -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=Off .  If you're not doing that, any change to atomic.c has no effect.


I see. In FreeBSD src/base, LLVM isn't using the standard cmake scripts, so we explicitly add atomic.c to the build, we don't set this flag (I did this: https://reviews.freebsd.org/D22549#change-3IJWKySKm5fg). However it's a good point, we must check if COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN is used for something else, and we should probably add the flag when building ports packages (devel/llvm*).  Thank you for pointing that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71600/new/

https://reviews.llvm.org/D71600