[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 05:07:42 PST 2020


ftynse marked an inline comment as done.
ftynse added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:50
+                    llvm::cl::desc("Emit C-compatible wrapper functions"),
+                    llvm::cl::init(false));
+
----------------
mehdi_amini wrote:
> Seems like you didn't provide tests for this flag?
Indeed, forgot to git add :/ Thanks for noticing. Pushed in ea3a25e4f5166ccd5e523f0165f5270b24d71f46.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211





More information about the llvm-commits mailing list