[PATCH] D74228: [PatternMatch] Match XOR variant of unsigned-add overflow check.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D74228#1867452 <https://reviews.llvm.org/D74228#1867452>, @spatel wrote:

> In D74228#1867093 <https://reviews.llvm.org/D74228#1867093>, @fhahn wrote:
>
> > It might be good to have tests that run instcombine & CGP to catch regressions such as this?
>
>
> Yes, that would be an improvement. Two potential options:
>
> 1. Add 'opt' RUNs that include CGP to llvm/test/Transforms/PhaseOrdering (this is probably stretching the intent of "PhaseOrdering"; we'll need a new target-specific test directory because CGP will require that we pick a target).
> 2. Add full end-to-end tests for C --> asm to test-suite.


I remember that there was a discussion on llvm-dev about this topic. Do you know if we already have similar tests in test-suite?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74228/new/

https://reviews.llvm.org/D74228