[PATCH] D54145: [ELF] - Fix R_X86_64_GOTPCRELX/R_X86_64_REX_GOTPCRELX when target is IFUNC.

Tue Feb 11 01:47:18 PST 2020

grimar abandoned this revision.
grimar added a comment.

In D54145#1868678 <https://reviews.llvm.org/D54145#1868678>, @MaskRay wrote:

> @grimar D57371 <https://reviews.llvm.org/D57371> fixed the "R_X86_64_REX_GOTPCRELX referencing ifunc should not be relaxed" bug, via the following line:
>
> > if (!Sym.IsPreemptible && !Sym.isGnuIFunc()) {
>
> `Target::adjustRelaxExpr` is not called for a non-preemptible ifunc. I think this patch is not needed.

I think you are right. Seems I did not realise that the last comment from Peter Wu (https://bugs.llvm.org/show_bug.cgi?id=38074#c9)
is actually a one+ year old when reopened the bug ~2 weeks ago.

Thank you for spotting!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54145/new/

https://reviews.llvm.org/D54145