[PATCH] D74373: AMDGPU/GlobalISel: Handle sbfe/ubfe intrinsic

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks OK to me, but it should probably be reviewed by someone more familiar with RegisterBankInfo.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1484
+  auto OffsetMask = B.buildConstant(S32, maskTrailingOnes<unsigned>(16));
+  auto ClampOffset = B.buildAnd(S32, OffsetReg, OffsetMask);
+
----------------
Is the behaviour of the intrinsic well-defined when the "offset" argument is huge enough for this to make a difference?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74373/new/

https://reviews.llvm.org/D74373