[PATCH] D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 22:49:17 PST 2020


jdoerfert added a comment.

In D72562#1857658 <https://reviews.llvm.org/D72562#1857658>, @sstefan1 wrote:

> > I was hoping that after D73313 <https://reviews.llvm.org/D73313> we could have a check this in `AAIsDeadCallSiteReturned`. In the init and update we ask H2S (and later others) if they assume to remove the instruction, if so, we consider it dead.
>
> Sorry for the delay.
>  Ok, I think this makes much more sense now.
>
> Can you do a rebase on D73313 <https://reviews.llvm.org/D73313> & D73311 <https://reviews.llvm.org/D73311>? I'm having trouble applying the patches.


Done, though I have some minor patches before them I'll commit tomorrow. If you find the time to review the two above I can commit the whole series ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72562/new/

https://reviews.llvm.org/D72562





More information about the llvm-commits mailing list