[PATCH] D74379: Fix SFINAE in llvm::bit_cast.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 20:25:28 PST 2020


jlebar created this revision.
Herald added subscribers: llvm-commits, dexonsmith.
Herald added a project: LLVM.
jlebar added a comment.
jlebar updated this revision to Diff 243724.
jlebar abandoned this revision.

Hm, thank you, arc, for including files that were not in my commit...


jlebar added a comment.

Attempt to remove files which shouldn't be in here.


jlebar added a comment.

arc is not cooperating; I'm going to delete this and create a new review.  Sorry for the noise.


As far as I can tell, the SFINAE was broken; there is no such thing as
std::is_trivially_constructible<T>::type.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74379

Files:
  .ycm_extra_conf.py
  llvm/include/llvm/ADT/bit.h
  testcases/mul.ll
  testcases/run-test
  testcases/shift-regression.ll
  testcases/shl.ll
  testcases/shl2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74379.243724.patch
Type: text/x-patch
Size: 5064 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200211/42d7c6f0/attachment.bin>


More information about the llvm-commits mailing list