[PATCH] D74364: [GWP-ASan] Update alignment on Android.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 17:54:26 PST 2020


morehouse added a comment.

Does Bionic's `malloc` have the required alignment information available at the call to `gwp_asan::allocate`?  If so, we could get tighter right alignment by adding an `alignment` parameter (instead of conservative 16-byte rounding).  This is the approach used in both Chrome and TCMalloc.

e.g., one of the most common malloc sizes is 24 (nodes in tree structures), which won't get perfectly right-aligned with the current approach, though it should be safe to do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74364/new/

https://reviews.llvm.org/D74364





More information about the llvm-commits mailing list