[PATCH] D68063: Propeller: LLVM support for basic block sections

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I'm not really happy with the way functions lists are handled:

1. It probably makes sense to encode as a function attribute, rather than sticking booleans directly onto llvm::Function .  Otherwise, we need to figure out a serialization story; we try to keep IR serialization as complete as possible, even as late as CodeGenPrepare.

2. Attaching the attributes should be done by a separate module pass, I think, not by jamming it into CodeGenPrepare.  CodeGenPrepare is an optimization, this isn't (at least, not in the same sense).

3. Not sure it makes sense to stick the list of functions into TargetMachine, as opposed to just modifying the module when the file is parsed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063