[PATCH] D73817: Add PassManagerImpl.h to hide implementation details

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Looks like polly was fixed here: rGd4c8230a0fdbcaf65 <https://reviews.llvm.org/rGd4c8230a0fdbcaf656701a81fdeeaa382d6254f5>

I guess I like the current code structure, but I don't feel that strongly about it. Even if moving the code back into the header but moving it out of the class body gets the same compile time benefits, it puts tokens into a widely included header that we don't need. The current structure raises the cost of instantiating new Pass & Analysis managers. You have to try to link, spot the link error, find the symbol, add the include as appropriate. Given how few instantiations (IR units) we expect there to be, it seems like a reasonable tradeoff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73817/new/

https://reviews.llvm.org/D73817