[PATCH] D73480: [VectorCombine] new IR transform pass for partial vector ops

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 13:57:40 PST 2020


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:34
+STATISTIC(NumVecCmp, "Number of vector compares formed");
+DEBUG_COUNTER(VecCombineCounter, "vector-combine-transform",
+              "Controls transformations in vector-combine pass");
----------------
craig.topper wrote:
> Is this counter used?
Oops - no. Copy/pasted from existing code. Looks like other passes do something like:
    if (!DebugCounter::shouldExecute(VecCombineCounter))
      continue;

I've never used that myself, so I could either add that code or remove the counter. Let me know if there's a preference. Not sure how we test it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73480/new/

https://reviews.llvm.org/D73480





More information about the llvm-commits mailing list