[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Currently the testing is very self-referential. Should we add a test in assembler (.s) in test/tools/llvm-dwarfdump that hardcodes a properly formatted macro section to make sure we don't add symmetric mistakes (where we implement the same mistake in both the generator and llvm-dwarfdump)?



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h:31
+    /// flags
+    // The bits of the flags field are interpreted as a set of flags, some of
+    // which may indicate that additional fields follow. The following flags,
----------------
nit: This should probably be one long doxygen comment. (i.e., use /// instead of //)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086