[PATCH] D74249: [DebugInfo] Support file-level include directories when generating Dwarf5 LineTable prologues.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 12:36:59 PST 2020


dblaikie added a comment.

In D74249#1866516 <https://reviews.llvm.org/D74249#1866516>, @jhenderson wrote:

> The change itself mostly looks fine to me, FWIW. An alternative to folding it into the other review would be to make a change in `checkDefaultPrologue` to check the new property of the FileNames, just like the name is already checked. The existing tests that use this function would then validate your changes.


Ah, makes sense. To avoid going through more cycles of review I went ahead and committed this patch with that suggested change in 0bd48c3d4ee1a94ea3d3b9d89201b23fd83c94d0 <https://reviews.llvm.org/rG0bd48c3d4ee1a94ea3d3b9d89201b23fd83c94d0>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74249/new/

https://reviews.llvm.org/D74249





More information about the llvm-commits mailing list