[PATCH] D74285: [EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083)

[Sanjay Patel via Phabricator via llvm-commits]

spatel updated this revision to Diff 243650.
spatel added a comment.

Patch updated:
The phase ordering test results were wrong in the earlier rev - I must have used a stale binary to generate the CHECK lines.
I fixed a bug in instcombine that was hindering the abs/nabs tests with:
rG62ce7e650a5a <https://reviews.llvm.org/rG62ce7e650a5a388540b5606d34bcce2fb5932498>

There's another bug for min/max, but I don't see a one-liner fix, so I've marked that test with a FIXME note after pushing
the baseline testing with:
rG0ad6e726ec7e <https://reviews.llvm.org/rG0ad6e726ec7eee8ef14a89fa288d5a1420d96b1e>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74285/new/

https://reviews.llvm.org/D74285

Files:
  llvm/lib/Transforms/Scalar/EarlyCSE.cpp
  llvm/test/Transforms/EarlyCSE/commute.ll
  llvm/test/Transforms/PhaseOrdering/min-max-abs-cse.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74285.243650.patch
Type: text/x-patch
Size: 9231 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200210/617a187a/attachment.bin>