[PATCH] D74288: [MLIR][Affine] Add affine.parallel op

Rob Earhart via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 12:00:26 PST 2020


earhart accepted this revision.
earhart added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: mlir/include/mlir/Dialect/AffineOps/AffineOps.td:288
+    "affine.terminator".  Calling AffineParallelOp::build will create such
+    region and insert the terminator, so will the parsing even in cases if it is
+    absent from the custom format.
----------------
This sentence seems slightly awkward -- maybe something like,
```
Calling AffineParallelOp::build will automatically create the required region and block, and insert the required terminator.  Parsing will also create the required region, block, and terminator, even when they are missing from the textual representation.

```
?  (Or maybe it's better to keep as-is, for consistency with `AffineForOp`...?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74288/new/

https://reviews.llvm.org/D74288





More information about the llvm-commits mailing list