[PATCH] D73988: Add documentation on git bisecting across the MLIR merge.

Mon Feb 10 11:24:06 PST 2020

thakis marked 2 inline comments as done.
thakis added a comment.

Thanks for the review, and sorry about dragging my feet -- my llvm repo was busy most of last week doing bisects :P

================
Comment at: llvm/docs/GitBisecting.rst:98
+merged, at every revision at ``C`` or earlier, *only* the ``mlir/`` directory
+exists, and nothing else does. This confused both ``git bisect`` and most
+run scripts.
----------------
mehdi_amini wrote:
> Why does it confuse `git bisect`? I would expect your run script to try ` ninja -C ../llvm-build-project clang || exit 125` and just skip the revisions?
I tried to reproduce the confused `git bisect`, but I only managed to do it if I hit ctrl-c during a bisect step. Let me replace this with a "don't hit ctrl-c while a bisect is running".

================
Comment at: llvm/docs/GitBisecting.rst:118
+``run.sh`` script does *not* work: git seems to get confused about the
+directories appearing and disappearing and soon errors out with XXX
+
----------------
mehdi_amini wrote:
> Seems like it answers my previous question (should this explanation be moved there?).
> 
> The part about git being confused about directories appearing and disappearing is a bit strange: surely there are many directories that will appear and disappear during the bisection?
See above. I'll remove this paragraph.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73988/new/

https://reviews.llvm.org/D73988