[PATCH] D74340: [CodingStandards] Clarify C++ Standard Library usage

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 10:13:29 PST 2020


rjmccall added a comment.

I think I would prefer if this were a somewhat less absolute statement, like:

> When both C++ and the LLVM support libraries provide similar functionality,
>  and there isn't a specific reason to favor the C++ implementation, it is
>  generally preferable to use the LLVM library.  For example, `llvm::DenseMap`
>  should almost always be used instead of `std::map` or `std::unordered_map`,
>  and `llvm::SmallVector` should usually be used instead of `std::vector`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74340/new/

https://reviews.llvm.org/D74340





More information about the llvm-commits mailing list