[PATCH] D74302: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/Linalg/EDSC/Intrinsics.h:28
 namespace intrinsics {
+namespace folded {
+/// Helper variadic abstraction to allow extending to any MLIR op without
----------------
nicolasvasilache wrote:
> ftynse wrote:
> > This looks generally useful, any reason why it's under Linalg/ ?
> The folder depends on FoldUtils which depends on StandardOps.
> Splitting it out of EDSC is necessary, since Linalg is the only user for now I put it here to untangle for now.
> Moved it to StandardOps for now but until FoldUtils drops the dependence (if possible?) it can't go at the top level.
> 
Let's have a ticket for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74302/new/

https://reviews.llvm.org/D74302