[PATCH] D60581: [ValueLattice] Make mark* functions public, return if value changed.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:292
+    assert(isConstant() && "No integer constant");
+    return dyn_cast<ConstantInt>(getConstant());
   }
----------------
nikic wrote:
> I'm confused -- how can this method ever return non-null? Isn't `ConstantInt` canonicalized to ranges?
Right, it looks like getConstantInt was an unused left-over. I've put up a patch to remove it: D74329


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60581/new/

https://reviews.llvm.org/D60581