[PATCH] D74325: [llvm-exegesis] Improve error reporting in Assembler.cpp

Miloš Stojanović via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 07:48:28 PST 2020


mstojanovic marked an inline comment as done.
mstojanovic added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:307
   if (!ExecEngine)
     report_fatal_error(Error);
   // Adding the generated object file containing the assembled function.
----------------
This is the only use of this function left in the tool but I ended up leaving it in because removing it would require adding a lot of boilerplate code due to its placement inside of a constructor.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74325/new/

https://reviews.llvm.org/D74325





More information about the llvm-commits mailing list