[PATCH] D74042: [test] Disable the Passes/PluginsTest cases on windows

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

In D74042#1865426 <https://reviews.llvm.org/D74042#1865426>, @mstorsjo wrote:

> In D74042#1864714 <https://reviews.llvm.org/D74042#1864714>, @thakis wrote:
>
> > Maybe only disable this in shared library builds?
>
>
> That's what I did originally, but then @rnk suggested disabling it altogether, as there seemed to be existing efforts not to leave stale test executables if switching shared libs on/off


Hm, I'm aware of one patch fixing something like that (by rnk), but I'm also aware of all the target unittest binaries being wrong on arch changes (`rg stale llvm/utils/gn/` finds one comment about being careful about getting it right, and one FIXME on where we don't). So I'm not sure I fully buy that :)

Anyhoo, if Reid likes it more this way, then let's do it.

But now that I look at the gn build files again, one of them is for this very directory, and it already does what the cmake file does after your patch. So maybe it used to be this way when I wrote the gn build file and then someone undid it?

Looks like I made the plugin link in Support in https://reviews.llvm.org/D47082 , then https://reviews.llvm.org/rL342150 (unreviewed?) undid that and broke Windows again.

Anyhoo, lgtm I suppose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74042/new/

https://reviews.llvm.org/D74042