[PATCH] D74285: [EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/EarlyCSE/commute.ll:344
 
+; Abs/nabs may exist with non-canonical operands. Value tracking can match those.
+; But we do not use value tracking, so we expect instcombine will canonicalize
----------------
samparker wrote:
> Probably worth adding a run line to run instcombine before earlycse to test this expectation?
Yes, good point. I prefer to make the tests part of "PhaseOrdering" though. That way we can easily test the standard optimization pipelines for each pass manager.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74285/new/

https://reviews.llvm.org/D74285