[PATCH] D74302: [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 06:12:16 PST 2020


nicolasvasilache added a comment.

@rriddle I did not see a simple way to untangle things and once I got things working I did not look back.
For instance, dropping dependencies from EDSC onto LoopOps and AffineOps requires extracting the makeLoopBuilder into a free function.
The only place where it makes sense to put this is in the loop dialect.
There are a bunch of similar cases.
At which point I don't see a reasonable way to split this up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74302/new/

https://reviews.llvm.org/D74302





More information about the llvm-commits mailing list