[PATCH] D74286: [ELF] Respect output section alignment for AT> (non-null lmaRegion)

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/test/ELF/linkerscript/lma-align.test:3
+# RUN: echo 'ret; .data.rel.ro; .balign 16; .byte 0;.data; .byte 0; .bss; .space 1' | \
+# RUN:   llvm-mc -filetype=obj -triple=x86_64 - -o %t.o
+# RUN: ld.lld -T %s %t.o -o %t
----------------
grimar wrote:
> 3 nits:
> 1) The space is missing `.byte 0;.data;` -> `.byte 0; .data;`
> 2) It is probably might be a matter of taste or may be related to my personal workflow, but still:
>     the constructions in test cases which use `|` like here do make things a bit more difficult to debug.
>     I.e. the asm file is not created, but sometimes it is useful to have it. Up to you probably as it is not
>     that hard to change when needed anyways.
> 3) Pardon my ignorance, but why `.space 1` for `.bss` and `.byte 0` for asm? Does it have a different meaning?
3) `for asm` -> `for .data`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74286/new/

https://reviews.llvm.org/D74286