[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

[Paul Robinson via Phabricator via llvm-commits]

probinson requested changes to this revision.
probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:840
+      if (Asm->TM.Options.ShouldEmitDebugEntryValues() &&
           (tuneForGDB() || tuneForLLDB())) {
         ParamSet Params;
----------------
This implementation makes it impractical to enable entry-values while still using SCE tuning.  The Sony debugger people will want to be able to do that.

And in fact this is not how tuning controls are supposed to work.  There should be a flag in DwarfDebug, initialized in the ctor, which has a *default* based on the tuning; but the flag can still be overridden regardless of tuning, by a command-line option just as many other tuning-related options are handled in the DwarfDebug ctor.

Based on comments by @vsk on the llvm-dev thread, I think you are trying to track all of the following conditions: (1) the target supports *tracking* entry values; (2) someone wants to *track* entry values even if the target doesn't support it by default; (3) whether to *emit* entry values in the DWARF.  Currently (3) is not user-selectable because it is hard-coded based on tuning; this is a bug.

I would also rather not have two separate command-line options for (2) and (3), but if that's what we need, so be it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534