[PATCH] D73919: [InstCombine] Use replaceOperand() in more places

Sat Feb 8 08:15:00 PST 2020

nikic marked an inline comment as done.
nikic added a comment.

I've now landed the swapValues use (rG9d03b7d0d008 <https://reviews.llvm.org/rG9d03b7d0d00833d81f31ff740491af6211262209>) and the creation of new insts (rGd4627b90a046 <https://reviews.llvm.org/rGd4627b90a0462c90a834c2f7b9c9228b3ec7a45b>) separately, and rebased this patch, so it now only includes the changes related to `replaceOperand()` use.

================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:1383-1385
+    replaceOperand(I, 0, A);
+    replaceOperand(I, 1, B);
     return &I;
----------------
spatel wrote:
> This is different than the CreateXor() changes below because of overflow flag propagation? If yes, it's worth a code comment.
That's right. I've now added a comment to indicate this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73919/new/

https://reviews.llvm.org/D73919