[PATCH] D74257: IR Linking: Support merging Warning+Max module metadata flags

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple minor suggestions below.
I think this makes sense.



================
Comment at: llvm/lib/Linker/IRMover.cpp:1357
+
+    if (DstBehaviorValue == Module::Max || SrcBehaviorValue == Module::Max) {
+      ConstantInt *DstValue =
----------------
A comment about why this isn't in the switch statement would be helpful, along with a note about how the new Flag is formed.

Also, it might be clearer to put this before the switch, after the new warning handling, with a continue to skip the then unnecessary switch (it consolidates the special case handling for Warning+Max).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74257/new/

https://reviews.llvm.org/D74257