[debuginfo-tests] 5752bcf - [DebugInfo]: Fix the debuginfo-tests/llgdb-tests/apple-accel.cpp test

[Jason Molenda via llvm-commits]

There was a failure because the test didn't start with a CHECK: - I fixed that in [master 4a18a5bdd9e], but now the incremental bot is showing a failure with




Command Output (stderr):
--

/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/debuginfo-tests/llgdb-tests/apple-accel.cpp:18:16: error: CHECK-NEXT: is not on the line after the previous match

// CHECK-NEXT: __debug_str
               ^
<stdin>:11:4: note: 'next' match was here
 5 __debug_str 000001bd 0000000000000165 DATA
   ^
<stdin>:9:16: note: previous match ended here
 3 __debug_info 000000a5 0000000000000090 DATA
               ^
<stdin>:10:1: note: non-matching line after previous match is here
 4 __debug_ranges 00000030 0000000000000135 DATA
^


http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/8262/consoleFull#146475001449ba4694-19c4-4d7e-bec5-911270d8a58c

I'm not sure I understand what the error output is trying to indicate, but is the order of these sections different than what the test expects again? I can't think of any reason why a specific ordering is guaranteed - this test seems very fragile if it is expecting a fixed ordering...



> On Feb 7, 2020, at 12:04 PM, Adrian Prantl <aprantl at apple.com> wrote:
> 
> Thank you! This LGTM.
> 
> -- adrian
> 
>> On Feb 7, 2020, at 11:58 AM, Sourabh Singh Tomar via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> 
>> Author: Sourabh Singh Tomar
>> Date: 2020-02-08T01:27:32+05:30
>> New Revision: 5752bcf9e5ace8dc4942ba2e044ec045b8da7eb0
>> 
>> URL: https://github.com/llvm/llvm-project/commit/5752bcf9e5ace8dc4942ba2e044ec045b8da7eb0
>> DIFF: https://github.com/llvm/llvm-project/commit/5752bcf9e5ace8dc4942ba2e044ec045b8da7eb0.diff
>> 
>> LOG: [DebugInfo]: Fix the debuginfo-tests/llgdb-tests/apple-accel.cpp test
>> failure after 84e5760.
>> 
>> Added: 
>> 
>> 
>> Modified: 
>>   debuginfo-tests/llgdb-tests/apple-accel.cpp
>> 
>> Removed: 
>> 
>> 
>> 
>> ################################################################################
>> diff  --git a/debuginfo-tests/llgdb-tests/apple-accel.cpp b/debuginfo-tests/llgdb-tests/apple-accel.cpp
>> index 6a94e5501189..444a0f980c56 100644
>> --- a/debuginfo-tests/llgdb-tests/apple-accel.cpp
>> +++ b/debuginfo-tests/llgdb-tests/apple-accel.cpp
>> @@ -13,9 +13,9 @@
>> __attribute__((section("1,__text_foo"))) void foo() {}
>> int main (int argc, char const *argv[]) { return argc; }
>> 
>> -// CHECK: __debug_str
>> // CHECK-NEXT: __debug_abbrev
>> // CHECK-NEXT: __debug_info
>> +// CHECK-NEXT: __debug_str
>> // CHECK-NEXT: __debug_ranges
>> // CHECK-NEXT: __apple_names
>> // CHECK-NEXT: __apple_objc
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>