[PATCH] D74246: [mlir][Pass] Enable printing pass options as part of `-help`.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Pass/PassOptions.h:188
+  /// map.
+  PassOptions(const PassOptions &) {}
+
----------------
jpienaar wrote:
> Why not make it non-copyable?
Done. I originally had this so that users could still call the copy constructor on Pass, but I just overrode that one as well.


================
Comment at: mlir/lib/Pass/PassRegistry.cpp:552
+                  "A textual description of a pass pipeline to run",
+                  /*indent=*/4, globalWidth, /*isTopLevel=*/!opt.hasArgStr());
+
----------------
jpienaar wrote:
> Any way to make these less magical? E.g., we have 4 here, 5 above, 6 below and 2 for indent (which is matches my editor config so I won't complain 😛 )
I aligned all of the magic. I need to do a followup to the core LLVM CommandLine library at some point to allow for passing in a base indent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74246/new/

https://reviews.llvm.org/D74246