[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM with an updated comment. I'll start a thread on llvm-dev about getting this patch landed soon, as everyone interested in this work may not have been following the patches. Perhaps it'd be best to wait to land this until folks have had 1-2 work days to respond to the thread.



================
Comment at: llvm/include/llvm/Target/TargetOptions.h:262
+    unsigned SupportsDebugEntryValues : 1;
+    ///  Emit the debug entry values.
     unsigned EnableDebugEntryValues : 1;
----------------
Better description might be: `When set to true, the EnableDebugEntryValues option forces production of debug entry values even if the target does not officially support it. Useful for testing purposes only. This flag should never be checked directly, always use \ref ShouldEmitDebugEntryValues instead.`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534