[PATCH] D74241: [GlobalISel][CallLowering] Look through bitcasts from constant function pointers

[Amara Emerson via Phabricator via llvm-commits]

aemerson created this revision.
aemerson added a reviewer: paquette.
aemerson added a project: LLVM.
Herald added subscribers: Petar.Avramovic, volkan, hiraditya, kristof.beyls, rovka.

Calls to ObjC's objc_msgSend function are done by bitcasting the function global to the required function type signature. This patch looks through this bitcast so that we can do a direct call with bl on arm64 instead of using an indirect blr.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74241

Files:
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/call-lowering-const-bitcast-func.ll


Index: llvm/test/CodeGen/AArch64/GlobalISel/call-lowering-const-bitcast-func.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AArch64/GlobalISel/call-lowering-const-bitcast-func.ll
@@ -0,0 +1,14 @@
+; RUN: llc -O0 -global-isel -verify-machineinstrs %s -o - 2>&1 | FileCheck %s
+
+target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
+target triple = "aarch64-darwin-ios13.0"
+
+declare i8* @objc_msgSend(i8*, i8*, ...)
+define void @call_bitcast_ptr_const() {
+; CHECK-LABEL: @call_bitcast_ptr_const
+; CHECK: bl _objc_msgSend
+; CHECK-NOT: blr
+entry:
+  call void bitcast (i8* (i8*, i8*, ...)* @objc_msgSend to void (i8*, i8*, [2 x i32], i32, float)*)(i8* undef, i8* undef, [2 x i32] zeroinitializer, i32 0, float 1.000000e+00)
+  ret void
+}
Index: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
+++ llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
@@ -52,8 +52,18 @@
 
   if (const Function *F = CS.getCalledFunction())
     Info.Callee = MachineOperand::CreateGA(F, 0);
-  else
-    Info.Callee = MachineOperand::CreateReg(GetCalleeReg(), false);
+  else {
+    // Try looking through a bitcast from one function type to another.
+    // Commonly happens with calls to objc_msgSend().
+    const Value *CalleeV = CS.getCalledValue();
+    if (auto *BC = dyn_cast<ConstantExpr>(CalleeV)) {
+      if (const auto *F = dyn_cast<Function>(BC->getOperand(0))) {
+        Info.Callee = MachineOperand::CreateGA(F, 0);
+      }
+    } else {
+      Info.Callee = MachineOperand::CreateReg(GetCalleeReg(), false);
+    }
+  }
 
   Info.OrigRet = ArgInfo{ResRegs, CS.getType(), ISD::ArgFlagsTy{}};
   if (!Info.OrigRet.Ty->isVoidTy())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74241.243236.patch
Type: text/x-patch
Size: 1803 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200207/7d8707f1/attachment.bin>