[PATCH] D74233: GlobalISel: Fix narrowScalar for G_{CTLZ|CTTZ}_ZERO_UNDEF

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 10:45:16 PST 2020


Petar.Avramovic accepted this revision.
Petar.Avramovic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3998-4000
+    auto LoCTLZ = IsUndef ?
+      B.buildCTLZ_ZERO_UNDEF(DstTy, UnmergeSrc.getReg(0)) :
+      B.buildCTLZ(DstTy, UnmergeSrc.getReg(0));
----------------
could use
    auto LoCTLZ = B.buildInstr(MI.getOpcode(), {DstTy}, {UnmergeSrc.getReg(0)});
for breviary. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74233/new/

https://reviews.llvm.org/D74233





More information about the llvm-commits mailing list